Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.62] Provide information to metro to redirect to rn-macos when building macos #596

Merged
merged 5 commits into from
Sep 15, 2020
Merged

[0.62] Provide information to metro to redirect to rn-macos when building macos #596

merged 5 commits into from
Sep 15, 2020

Conversation

acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Sep 14, 2020 •
edited by ghost
Loading

Port #587 to 0.62

Microsoft Reviewers: Open in CodeFlow

@acoates-ms
Provide information to metro to redirect to rn-macos when building ma…
462cceb 
…cos (facebook#587)

* Provide information to metro to redirect to rn-macos when building macos

* Update version of cli we are using

* more config

Co-authored-by: Andrew Coates <[email protected]>
@acoates-ms acoates-ms requested a review from tom-un as a code owner September 14, 2020 18:22
@pull-bot
Copy link

pull-bot commented Sep 14, 2020 •
edited
Loading

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 7bbe4f7

@acoates-ms
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ghost
Copy link

ghost commented Sep 14, 2020

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@acoates-ms acoates-ms merged commit f59ede3 into microsoft:0.62-stable Sep 15, 2020
alloy
alloy reviewed Sep 16, 2020
View reviewed changes
.ado/android-pr.yml
@@ -8,6 +8,7 @@ pr:
include:
- master
- 0.59-stable
- 0.62-stable
Copy link
Member

@alloy alloy Sep 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t these (going forward in master) be *-stable?

alloy
alloy reviewed Sep 16, 2020
View reviewed changes
.ado/templates/react-native-macos-init.yml
@@ -63,7 +63,7 @@ steps:
- task: CmdLine@2
displayName: Bump package version
inputs:
script: node scripts/bump-oss-version.js --nightly
script: node scripts/bump-oss-version.js --ci 0.62.1000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we now have to update this every time we create a new stable branch or could this be inferred by the script from the current branch name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bump the stable version of the react-native-macos package we use a different script. Would it be possible to use that here too and not introduce forked changes to the bump-oss-version.js script?

@tom-un tom-un mentioned this pull request Sep 21, 2020
Merged
4 tasks
@acoates-ms acoates-ms deleted the metroconfig62 branch September 2, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alloy alloy alloy left review comments

@tom-un tom-un Awaiting requested review from tom-un tom-un is a code owner

Assignees
No one assigned
Labels
AutoMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acoates-ms @pull-bot @alloy